Always enable 'Check for Updates' menu button#11485
Merged
Merged
Conversation
calixtus
reviewed
Jul 11, 2024
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
calixtus
reviewed
Jul 17, 2024
Comment on lines
-64
to
-67
| if (!internalPreferences.isVersionCheckEnabled()) { | ||
| return; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Does this change mean, jabref will now always check on startup, if a new version is present?
This can be very annoying, if you explicitly want to stay on an older version, if the newer one has a bug.
Member
Author
There was a problem hiding this comment.
This method will only execute when using Help -> Check for updates, so it shouldn't perform any checks.
The other method, checkForNewVersionDelayed() (Line 70), used to check for updates on startup, will only be called if it is enabled in the preferences.
jabref/src/main/java/org/jabref/gui/JabRefGUI.java
Lines 111 to 119 in 7e4e7d3
Siedlerchr
previously approved these changes
Jul 17, 2024
Siedlerchr
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/470
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)