Skip to content

Fix missing external changes resolver dialog scrollbar #11415

Merged
Siedlerchr merged 4 commits into
JabRef:mainfrom
alexandre-cremieux:fix-issue-11220
Jun 23, 2024
Merged

Fix missing external changes resolver dialog scrollbar #11415
Siedlerchr merged 4 commits into
JabRef:mainfrom
alexandre-cremieux:fix-issue-11220

Conversation

@alexandre-cremieux

Copy link
Copy Markdown
Contributor

Closes issue 1120

See screenshots bellow.

And refactor some code from the org.jabref.gui.collab package:

  • Make the anchor pane offset configuration common for all subclasses of org.jabref.gui.collab.DatabaseChangeDetailsView
  • Replace the pattern mathing for if statement by a pattern matching for switch statement in org.jabref.gui.collab.DatabaseChangeDetailsViewFactory and remove the related TODO

Please read commits one by one to make PR easier to understand.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the iorg.jabref.gui.collab.DatabaseChangeDetailsViewFactorynformation available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

scrollable-metada-changes-review
boxed-group-tree-modification-message

@Siedlerchr

Copy link
Copy Markdown
Member

Tested it, looks good. Please have a look at the checkstyle error

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 22, 2024
@alexandre-cremieux

Copy link
Copy Markdown
Contributor Author

Hello @Siedlerchr ,

Thanks for the test. I corrected the checkstyle error.

Siedlerchr
Siedlerchr previously approved these changes Jun 22, 2024
@Siedlerchr Siedlerchr enabled auto-merge June 22, 2024 19:03
@Siedlerchr

Copy link
Copy Markdown
Member

I just saw the open rewrite error, can you execute ./gradlew rewriteRun and commit your changes?

auto-merge was automatically disabled June 23, 2024 16:06

Head branch was pushed to by a user without write access

@alexandre-cremieux

alexandre-cremieux commented Jun 23, 2024

Copy link
Copy Markdown
Contributor Author

@Siedlerchr done.

I didn't know that tool. Very interesting, especially for contributions. The lossless semantic tree seems to be a powerful model. Have you seen interesting improvements in the code base since you started to use Open Rewrite ?

@Siedlerchr

Copy link
Copy Markdown
Member

It's great for doing migrations or automatic refactoring e.g with more modern Java methods
Does not always work 100%, we had some quirks where it did not work but we reported the bugs and they got fixed.
It depends a bit on the recipes

@Siedlerchr Siedlerchr enabled auto-merge June 23, 2024 16:58
@Siedlerchr Siedlerchr added this pull request to the merge queue Jun 23, 2024
Merged via the queue into JabRef:main with commit 3401b71 Jun 23, 2024
@alexandre-cremieux

Copy link
Copy Markdown
Contributor Author

Going to take a look. For now, it seems quite fresh but I like the approach. At least, automatic migrations can save days of development time, not saying it is a low value added work.

Thanks. Will look soon for another contribution to JabRef.

@alexandre-cremieux alexandre-cremieux deleted the fix-issue-11220 branch June 23, 2024 17:21
@koppor

koppor commented Jun 24, 2024

Copy link
Copy Markdown
Member

@alexandre-cremieux There is a whole company doing business with this rewrite. See https://docs.openrewrite.org/ for more information. -- Looking forward to more contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make External Changes Resolver dialog scrollable

3 participants