Fix missing external changes resolver dialog scrollbar #11415
Conversation
|
Tested it, looks good. Please have a look at the checkstyle error |
…ion in DatabaseChangeDetailsViewFactory ref: JabRef#11220
5030fc2 to
8b3e2c7
Compare
|
Hello @Siedlerchr , Thanks for the test. I corrected the checkstyle error. |
|
I just saw the open rewrite error, can you execute ./gradlew rewriteRun and commit your changes? |
Head branch was pushed to by a user without write access
8b3e2c7 to
8f91bf1
Compare
|
@Siedlerchr done. I didn't know that tool. Very interesting, especially for contributions. The lossless semantic tree seems to be a powerful model. Have you seen interesting improvements in the code base since you started to use Open Rewrite ? |
|
It's great for doing migrations or automatic refactoring e.g with more modern Java methods |
|
Going to take a look. For now, it seems quite fresh but I like the approach. At least, automatic migrations can save days of development time, not saying it is a low value added work. Thanks. Will look soon for another contribution to JabRef. |
|
@alexandre-cremieux There is a whole company doing business with this rewrite. See https://docs.openrewrite.org/ for more information. -- Looking forward to more contributions! |
Closes issue 1120
See screenshots bellow.
And refactor some code from the org.jabref.gui.collab package:
Please read commits one by one to make PR easier to understand.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)