Skip to content

Streamline code in EntryEditor#11379

Merged
koppor merged 3 commits into
mainfrom
improve-entry-editor
Jun 17, 2024
Merged

Streamline code in EntryEditor#11379
koppor merged 3 commits into
mainfrom
improve-entry-editor

Conversation

@koppor

@koppor koppor commented Jun 17, 2024

Copy link
Copy Markdown
Member

In the context of another PR, I needed to work with the EntryEditor. I moved the refactorings out to a separate PR.

  • Introduce interface OffersPreview
  • Merge two lists of tabs
  • Introduce method
  • Rename variables

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Streamline code in EntryEditor
3de60c6 
- Introduce interface OffersPreview
- Merge two lists of tabs
- Introduce method
- Rename variables
@koppor koppor added the dev: code-quality Issues related to code or architecture decisions label Jun 17, 2024
calixtus
calixtus reviewed Jun 17, 2024
View reviewed changes
Comment thread src/main/java/org/jabref/gui/entryeditor/EntryEditor.java Outdated
calixtus
calixtus reviewed Jun 17, 2024
View reviewed changes
Comment thread src/main/java/org/jabref/gui/entryeditor/OffersPreview.java
calixtus
calixtus previously approved these changes Jun 17, 2024
View reviewed changes
calixtus
calixtus previously approved these changes Jun 17, 2024
View reviewed changes
@koppor koppor enabled auto-merge June 17, 2024 09:40
@koppor koppor added this pull request to the merge queue Jun 17, 2024
@github-actions

github-actions Bot commented Jun 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit a2bd254 Jun 17, 2024
@koppor koppor deleted the improve-entry-editor branch June 17, 2024 09:57
@koppor koppor mentioned this pull request Jun 17, 2024
Merged
6 tasks
@LoayGhreeb LoayGhreeb mentioned this pull request Jul 17, 2024
Merged
6 tasks
@alexandre-cremieux alexandre-cremieux mentioned this pull request Sep 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

dev: code-quality Issues related to code or architecture decisions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koppor @calixtus