Skip to content

Update lucene branch#11326

Closed
LoayGhreeb wants to merge 170 commits into
JabRef:mainfrom
LoayGhreeb:update-lucene-branch
Closed

Update lucene branch#11326
LoayGhreeb wants to merge 170 commits into
JabRef:mainfrom
LoayGhreeb:update-lucene-branch

Conversation

@LoayGhreeb

@LoayGhreeb LoayGhreeb commented May 26, 2024

Copy link
Copy Markdown
Member

This is a follow-up to #8963. We target main, because targetting luceneSearchBackend leads to much more "unrelated" commits.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

btut and others added 30 commits July 9, 2022 11:38
A user might have deleted a link to a fulltext-file in the source tex
file and we need to reflect that change in the index as well.
Make the results-counter react on the correct observables and actually
filter out results with score == 0
Lucene cannot do case-sensitive search
@koppor

koppor commented Jul 3, 2024

Copy link
Copy Markdown
Member

@koppor koppor changed the base branch from main to luceneSearchBackend July 3, 2024 07:01
@koppor koppor changed the base branch from luceneSearchBackend to main July 3, 2024 07:02
@koppor koppor changed the base branch from main to luceneSearchBackend July 3, 2024 08:33
@koppor koppor changed the base branch from luceneSearchBackend to main July 3, 2024 08:58
@LoayGhreeb LoayGhreeb force-pushed the update-lucene-branch branch from 43b43a0 to 8abee27 Compare July 10, 2024 15:05
@koppor

koppor commented Jul 27, 2024

Copy link
Copy Markdown
Member

I triggered a merge. Maybe, the tests will work then again? - I also hope that we will see a build at https://builds.jabref.org/pull/11326/.

@koppor

koppor commented Jul 27, 2024

Copy link
Copy Markdown
Member

This branch is coming from an external repository; therefore, no secrets for build upload are present. Testers need to compile for themselves on the local machine.

Depending on the issues, we either work towards a quick merge into main - or create a branch inside the JabRef main repository (and maybe create a new pull request).

@LoayGhreeb

Copy link
Copy Markdown
Member Author

This branch is coming from an external repository; therefore, no secrets for build upload are present. Testers need to compile for themselves on the local machine.

Depending on the issues, we either work towards a quick merge into main - or create a branch inside the JabRef main repository (and maybe create a new pull request).

I will create a new branch and a new pull request. This PR should be merged after the search floating mode PR is merged.

@LoayGhreeb LoayGhreeb closed this Jul 28, 2024
@LoayGhreeb LoayGhreeb mentioned this pull request Jul 28, 2024
6 tasks
@LoayGhreeb LoayGhreeb deleted the update-lucene-branch branch September 6, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants