Fix import selected groups#11271
Merged
Merged
Conversation
2 tasks
HoussemNasri
reviewed
May 1, 2024
HoussemNasri
reviewed
May 1, 2024
| * @return The generated UID in UUIDv4 format | ||
| */ | ||
| public String getUid() { | ||
| return uid; |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
I was thinking about such things as well and tried some things, however
- A new unsaved database doesn't have a path
- If it's a shared database it doesn't have a path as well, it has a shared database
- Saving under a new path/name will change the key, and we lose the reference
However, I now added the prefix bibdatabasecontext to. make it a bit more clear where the uid is related to
Member
There was a problem hiding this comment.
How about?
if databasename is empty:
uid = "bibdatabasecontext_${uid}"
else
uid = "${databasename}_${uid}"
Member
There was a problem hiding this comment.
Saving under a new path/name will change the key, and we lose the reference
Ah okay I see, I'm fine with the bibdatabasecontext_ prefix for now but we really should consider other options later.
HoussemNasri
reviewed
May 1, 2024
add changelog entries
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
HoussemNasri
approved these changes
May 2, 2024
HoussemNasri
left a comment
Member
There was a problem hiding this comment.
LGTM! Sorry for the delay to approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #11085
Fixes #11269
Fixes #8933
Equals/hashcode changes too much
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)