Bring back a modified ISBN check and add more tests#11217
Merged
Conversation
Signed-off-by: AbdAlRahmanGad <abdobngad@gmail.com>
koppor
requested changes
Apr 18, 2024
koppor
left a comment
Member
There was a problem hiding this comment.
Thank you for the follow-up. Small comment remaining.
Signed-off-by: AbdAlRahmanGad <abdobngad@gmail.com>
koppor
reviewed
Apr 18, 2024
Comment on lines
+347
to
+349
| if (oneISBN.isPresent() && twoISBN.isPresent() | ||
| && !List.of(StandardEntryType.Article, StandardEntryType.InBook, StandardEntryType.InCollection).contains(one.getType()) | ||
| && Objects.equals(oneISBN, twoISBN)) { |
Member
There was a problem hiding this comment.
I would flip List.of and Objects.equals, because oneISBN is checked in line 347 and then the subsequent line 348 is closer. Otherwise, the condition is harder to read, because it switches between ISBN, types, and ISBN.
Signed-off-by: AbdAlRahmanGad <abdobngad@gmail.com>
koppor
approved these changes
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8885
jabref/src/main/java/org/jabref/logic/database/DuplicateCheck.java
Line 334 in 6789460
to ensure that the types are the same first.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)