Skip to content

Remove WARNING outputs at "run"#11209

Merged
Siedlerchr merged 1 commit into
mainfrom
remove-module-warnings
Apr 16, 2024
Merged

Remove WARNING outputs at "run"#11209
Siedlerchr merged 1 commit into
mainfrom
remove-module-warnings

Conversation

@koppor

@koppor koppor commented Apr 16, 2024

Copy link
Copy Markdown
Member

Follow-up to #11195

When running JabRef using gradle, one gets following outputs:

WARNING: Unknown module: org.jabref.merged.module specified to --add-exports
WARNING: Unknown module: org.jabref.merged.module specified to --add-exports
WARNING: Unknown module: org.jabref.merged.module specified to --add-opens
WARNING: Unknown module: org.jabref.merged.module specified to --add-opens
WARNING: Unknown module: org.jabref.merged.module specified to --add-opens

They are caused by our new applicationDefaultJvmArgs entry. That entry is needed for our jpackage task.

However, for run, they are not needed. Thus, this PR adds a "hot patch" to the run task to avoid that output.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions

github-actions Bot commented Apr 16, 2024

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr enabled auto-merge April 16, 2024 18:22
@Siedlerchr Siedlerchr added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 346d85a Apr 16, 2024
@Siedlerchr Siedlerchr deleted the remove-module-warnings branch April 16, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants