Add tooltip for cell content and entries' preview in Main Table#11176
Conversation
| this.undoManager = undoManager; | ||
| this.stateManager = stateManager; | ||
| this.tooltip = new MainTableTooltip(database, dialogService, preferencesService, stateManager, | ||
| JabRefGUI.getThemeManager(), taskExecutor); |
There was a problem hiding this comment.
Pleas pass the ThemeManager via constructor (Dependency Inversion Principle)
There was a problem hiding this comment.
@Siedlerchr This entails adding ThemeManager as a constructor parameter for dozen other classes. Should I still do it?
There was a problem hiding this comment.
Yes, I know this sounds crazy but we don't have really any good dependency injection.
But most of the calling classes should already have the theme manager, so I hope it's only a handful of classes that need ajustment
There was a problem hiding this comment.
@Siedlerchr I think it's 17 files
commit
There was a problem hiding this comment.
ThemeManager themeManager = Injector.instantiateModelOrService(ThemeManager.class);
is a temporary solution until we have a proper di solution.
|
lgtm |
This reverts commit 04774cc.
Closes #10925
Added tooltip for Main Table cells which shows cell content and optionally entry's preview. A checkbox in Preview Tab is added to toggle on and off entry's preview.
When checkbox in Preview Tab is toggled off, only cell content is shown.
Toggle off "show preview in entry table tooltip" checkbox
Check that tooltip shows only cell content
When checkbox in Preview Tab is toggled on, cell content and entry preview is shown
Toggle on "show preview in entry table tooltip" checkbox
Check that tooltip shows cell content and entry preview
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)