Include JavaFX jmods (and remove forceMerge javaFX) by koppor · Pull Request #11170 · JabRef/jabref

koppor · 2024-04-09T00:49:03Z

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/412

After this is done:

Report small howto to Support missing for jdk.packager.services / UserJvmOptionsService ? openjfx/javafx-gradle-plugin#60

Mandatory checks

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor · 2024-04-09T07:37:57Z

Messages are not initialized before accessing key: Display help on command line options
2024-04-09 09:37:26 [JavaFX-Launcher] sun.util.logging.internal.LoggingProviderImpl$JULWrapper.log()
WARN: Unsupported JavaFX configuration: classes were loaded from 'module org.jabref.merged.module', isAutomatic: false, isOpen: true
Exception in thread "JavaFX-Launcher" java.lang.NoSuchMethodError: notifyThemeChanged
        at org.jabref.merged.module@5.14.33/com.sun.glass.ui.win.WinApplication.initIDs(Native Method)

# Java VM: OpenJDK 64-Bit Server VM Temurin-22+36 (22+36, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, windows-amd64)

Siedlerchr · 2024-04-09T07:45:49Z

In 21u it's still present https://github.com/openjdk/jfx21u/blob/c2600685dbba9f33e01b9b0fcf2346df9b5e0011/modules/javafx.graphics/src/main/java/com/sun/glass/ui/Application.java#L262
In 22 it was changed to a new method: openjdk/jfx@170a4c1

koppor · 2024-04-09T07:48:33Z

Foojay Gradle Plugin seems to stick to Temurin:

# Java VM: OpenJDK 64-Bit Server VM Temurin-22+36 (22+36, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, windows-amd64)

koppor · 2024-04-09T13:09:22Z

Also happens when using Zulu:

# JRE version: OpenJDK Runtime Environment Zulu22.28+93-CRaC-CA (22.0+36) (build 22+36)

koppor · 2024-04-09T13:35:47Z

Linux:

Loading library prism_es2 from resource failed: java.lang.UnsatisfiedLinkError: /home/koppor/.openjfx/cache/23-ea+12/amd64/libprism_es2.so: libXxf86vm.so.1: cannot open shared object file: No such file or directory
java.lang.UnsatisfiedLinkError: /home/koppor/.openjfx/cache/23-ea+12/amd64/libprism_es2.so: libXxf86vm.so.1: cannot open shared object file: No such file or directory
        at java.base/jdk.internal.loader.NativeLibraries.load(Native Method)

Siedlerchr · 2024-04-09T15:11:06Z

Oh finally after 10 hours?

koppor · 2024-04-10T08:10:27Z

Error: Modules org.jabref.merged.module and javafx.base export package javafx.beans.property to module com.dlsc.gemsfx

Siedlerchr · 2024-04-10T08:18:14Z

    // but it was removed in the newer releases.
    // The pom.xml associated with such a non-modular artifact does not mention that the artifact depends on the removed code
    // (because the artifact was published when this code was still available in the JDK).
-    forceMerge "javafx"


this will not work this is intended for our merged module so that javafx is part of the merge module and can therefore be found

you could try to add gemsfx to the merged module declaration

Based on the comments above, I was thinking, it could help.

Two versions of module javafx.graphics found in /Users/runner/work/***/***/build/jlinkbase/jlinkjars (javafx-graphics-20-mac.jar and javafx.graphics.jar)

This sounds like the downloading of javafx is wrong because we load it over our plugin and this will clash

/home/runner/.gradle/caches/modules-2/files-2.1/org.openjfx/javafx-base/20/d82ec648e48647e10125ff0e3dce70348a80ac18/javafx-base-20-linux.jar

This is likely the main culprit:

jabref/build.gradle

Lines 104 to 107 in b140d8a

javafx {

version = "22"

modules = [ 'javafx.controls', 'javafx.fxml', 'javafx.web', 'javafx.swing' ]

}

https://github.com/openjfx/javafx-gradle-plugin

(I document more for myself than for others)

This is likely the main culprit:

No.

This points to JavaFX 22, not 22. The file included is /home/runner/.gradle/caches/modules-2/files-2.1/org.openjfx/javafx-base/20/d82ec648e48647e10125ff0e3dce70348a80ac18/javafx-base-20-linux.jar and thus is 20 (twenty) not 22 (twenty-two)

I replace version by sdk in the yaml workflow:

jabref/.github/workflows/deployment-jdk-ea.yml

Line 166 in f6a7217

sed -i '/javafx {/{n;s#version = ".*"#sdk = "javafx/javafx-sdk-${{ matrix.javafx }}"#}' build.gradle

I seee, but they are still duplicated on the classpath

Only with the -20 or do you see other duplicates?

Maybe beryx/badass-jlink-plugin#61 (comment) helps. Currently checking.

koppor · 2024-04-10T19:59:12Z

Both the sdk and the jmods are available at https://jdk.java.net/javafx23/. Unzip in javafx sub directory.

This reverts commit f2d18cd.

koppor · 2024-04-10T20:44:29Z

JDK: Corretto (Temurin did not work(
removed forceMerge (0c87bdd (#11170) and added requires statements (a96d0f9 (#11170)

Result:

Siedlerchr · 2024-04-10T20:46:20Z

pipeline still failing? /home/runner/work/jabref/jabref/build/jlinkbase/tmpjars/org.jabref.merged.module/module-info.java:1113: error: module not found: javafx.base

Siedlerchr · 2024-04-10T20:48:32Z

sure you did a ./gradlew clean before locally?

koppor · 2024-04-10T20:49:31Z

No clean: BELLSOFT same error, Corretto: no error

Now, trying clean locally.

koppor · 2024-04-10T21:33:00Z

With Amazon Corretto:

github-actions · 2024-04-10T21:48:25Z

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

koppor added 3 commits April 9, 2024 02:48

Switch from temurin to adoptium

292429d

Try zulu

7bcf4a0

Upload to artifact store

4800fea

Siedlerchr changed the title ~~Switch from temurin to adoptium~~ Switch from temurin to Zulu Apr 9, 2024

koppor added 3 commits April 9, 2024 10:46

Set vendor to zulu (AKA AZUL)

b30dbd9

Fix rsync step condition

e7fe460

Replace "Setup" by "Set up"

cfd7a53

koppor added 2 commits April 9, 2024 15:59

Reorder - and try to download jmods

b985107

Try to fix extract

7ea267a

Siedlerchr reviewed Apr 9, 2024

View reviewed changes

Comment thread .github/workflows/deployment-jdk-ea.yml

koppor added 3 commits April 9, 2024 16:26

Try to fix remove

267be3a

Fix quotes

0e711c7

Fix build.gradle

2ab5396

Maybe JavaFX is now modular?

79dc5b3

Siedlerchr reviewed Apr 10, 2024

View reviewed changes

koppor added 8 commits April 10, 2024 10:57

Try to find where this library comes from

b770324

Purge old JavaFX versions

30dad6b

Add missing condition

f6a7217

Some more debug

2aefa99

Fix debug

b624617

Disable caching

d254722

Try other requires (instead of forcing merge)

8e6c7d5

Try to shrink build cache

09ef4a9

koppor added 7 commits April 10, 2024 22:03

Remove forceMerge of JavaFX

0c87bdd

Switch back to default JDK

f2d18cd

Add requires statements

a96d0f9

Revert "Switch back to default JDK"

7477afc

This reverts commit f2d18cd.

Add comment on JDK

29e1684

Use Amazon's JDK

28cd793

Add jmods dir to .gitignore

cd44bcb

koppor added 2 commits April 10, 2024 22:59

Remove "|| true" in pipeline (for gradle)

8ebf012

Add "addExtraDependencies("javafx")"

70501fa

github-actions Bot reviewed Apr 10, 2024

View reviewed changes

Comment thread build.gradle Outdated

koppor added 2 commits April 10, 2024 23:20

Tabs -> Spaces

0d38de8

Switch back to default JDK

487124c

Revert liberica -> temurin

1c584a7

koppor marked this pull request as ready for review April 10, 2024 21:37

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 10, 2024

koppor changed the title ~~Include JMODS (and switch from temurin/liberica to adopt)~~ Include JavaFX jmods (and remove forceMerge javaFX) Apr 10, 2024

calixtus approved these changes Apr 10, 2024

View reviewed changes

calixtus added this pull request to the merge queue Apr 10, 2024

Merged via the queue into main with commit aa0fa84 Apr 10, 2024

calixtus deleted the koppor-patch-2 branch April 10, 2024 22:03

This was referenced Apr 15, 2024

Add export of com.sun.javafx.event to org.jabref #11195

Merged

InaccessibleObjectException #11198

Closed

	javafx {
	version = "22"
	modules = [ 'javafx.controls', 'javafx.fxml', 'javafx.web', 'javafx.swing' ]
	}

Uh oh!

Conversation

koppor commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mandatory checks

Uh oh!

koppor commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siedlerchr commented Apr 9, 2024

Uh oh!

koppor commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koppor commented Apr 9, 2024

Uh oh!

koppor commented Apr 9, 2024

Uh oh!

Uh oh!

Siedlerchr commented Apr 9, 2024

Uh oh!

koppor commented Apr 10, 2024

Uh oh!

Siedlerchr Apr 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

koppor Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Apr 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koppor Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Apr 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koppor Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

koppor Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

koppor Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

koppor commented Apr 10, 2024

Uh oh!

koppor commented Apr 10, 2024

Uh oh!

Siedlerchr commented Apr 10, 2024

Uh oh!

Siedlerchr commented Apr 10, 2024

Uh oh!

koppor commented Apr 10, 2024

Uh oh!

Uh oh!

koppor commented Apr 10, 2024

Uh oh!

github-actions Bot commented Apr 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

koppor commented Apr 9, 2024 •

edited

Loading

koppor commented Apr 9, 2024 •

edited

Loading

koppor commented Apr 9, 2024 •

edited

Loading

Siedlerchr Apr 10, 2024 •

edited

Loading

Siedlerchr Apr 10, 2024 •

edited

Loading

Siedlerchr Apr 10, 2024 •

edited

Loading

github-actions Bot commented Apr 10, 2024 •

edited

Loading