Skip to content

Add keyboard shortcut Ctrl + , to open preferences#11154

Merged
Siedlerchr merged 2 commits into
JabRef:mainfrom
jeanprbt:add-preferences-shortcut
Apr 5, 2024
Merged

Add keyboard shortcut Ctrl + , to open preferences#11154
Siedlerchr merged 2 commits into
JabRef:mainfrom
jeanprbt:add-preferences-shortcut

Conversation

@jeanprbt

@jeanprbt jeanprbt commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

This PR adds the keyboard shortcut Ctrl + , to open the preferences.

Capture d’écran 2024-04-05 à 18 30 33

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@jeanprbt

jeanprbt commented Apr 5, 2024

Copy link
Copy Markdown
Contributor Author

I am just struggling adding this new keyboard shortcut to the table of shortcuts in the Key bindings preferences tab. Any idea ? Every shortcut seems to be added to the keyBindingsRepository of the KeyBindingsTabView class, but I do not find where it is initalized.

Siedlerchr
Siedlerchr reviewed Apr 5, 2024
View reviewed changes
Comment thread CHANGELOG.md Outdated

### Added

- We added key binding to open preferences <kbd>ctrl</kbd> + <kbd>,</kbd>

@Siedlerchr Siedlerchr Apr 5, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to your other PR this must be now keyboard shortcut!

@Siedlerchr

Siedlerchr commented Apr 5, 2024

Copy link
Copy Markdown
Member

I am just struggling adding this new keyboard shortcut to the table of shortcuts in the Key bindings preferences tab. Any idea ? Every shortcut seems to be added to the keyBindingsRepository of the KeyBindingsTabView class, but I do not find where it is initalized.

It's handled over the StandardActions enum

jabref/src/main/java/org/jabref/gui/MainMenu.java

Line 157 in 2ba3b2a

factory.createMenuItem(StandardActions.SHOW_PREFS, new ShowPreferencesAction(frame, dialogService)),

From there on it goes over to the createMenuItem stuff where it is associated with the menuItem

Siedlerchr
Siedlerchr reviewed Apr 5, 2024
View reviewed changes
Comment thread CHANGELOG.md Outdated
@Siedlerchr Siedlerchr enabled auto-merge April 5, 2024 20:23
@Siedlerchr Siedlerchr added this pull request to the merge queue Apr 5, 2024
Merged via the queue into JabRef:main with commit 67314ba Apr 5, 2024
@jeanprbt jeanprbt deleted the add-preferences-shortcut branch April 5, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeanprbt @Siedlerchr