Change "Key bindings" to "Keyboard shortcuts"#11153
Merged
Merged
Conversation
Member
|
The "key binding" should not appear in the language file any more. If it does, you missed some string. (Or adapt the PR description) Reason: We do not keep unused strings. |
Contributor
Author
|
Sorry about that, I updated the PR description. All occurrences of "key bindings" are in fact replaced by "keyboard shortcuts". |
Member
|
Changelog entry please under "changed" section |
Siedlerchr
reviewed
Apr 5, 2024
Siedlerchr
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Preferences tab for Key bindings, renaming it to Keyboard shortcuts. It updates the tab title, the page title and the messages when changing keyboard shortcuts. This follows a request from @koppor on the Gitter channel.
This PR updates the file in
resources/l10n/JabRef_en.propertiesto replace all occurrences ofkey\ bindingswithkeyboard\ shortcuts.Mandatory checks
Change inCHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)Tests created for changes (if applicable)