Do no export file field in XMP#11083
Merged
Merged
Conversation
koppor
reviewed
Mar 23, 2024
| olly2018.setField(StandardField.OWNER, "me"); | ||
| olly2018.setField(StandardField.REVIEW, "review"); | ||
| olly2018.setField(StandardField.URL, "https://www.olly2018.edu"); | ||
| OLLY_2018.setCitationKey("Olly2018"); |
Member
There was a problem hiding this comment.
Can we do withCitationKey and move the initialization to the variable?
Member
Author
There was a problem hiding this comment.
Yes, but moving the initialization to the variable is a bad idea due to how the test works. Due to MethodSources it has to be static and we are setting the vars to the correct values and we are resetting them again.
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
koppor
approved these changes
Mar 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/271
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)