CHanges made in setupModeButtons to address toggling of buttons issue#10987
Merged
Conversation
* upstream/main: (40 commits) Improve citation relations (JabRef#11016) Keep enclosing braces of authors (JabRef#11034) Bump org.apache.pdfbox:fontbox from 3.0.1 to 3.0.2 (JabRef#11042) Bump com.dlsc.gemsfx:gemsfx from 2.2.0 to 2.4.0 (JabRef#11044) Bump org.apache.pdfbox:xmpbox from 3.0.1 to 3.0.2 (JabRef#11041) Bump com.googlecode.plist:dd-plist from 1.23 to 1.28 (JabRef#11040) Bump gittools/actions from 0.13.4 to 1.1.1 (JabRef#11039) Change copy-paste function to handle string constants (follow up PR) (JabRef#11037) Fixes Zotero file handling for absolute paths (JabRef#11038) Speed up failure reporting (JabRef#11030) Importing of BibDesk Groups and Linked Files (JabRef#10968) Convert RemoveBracesFormatterTest to @ParameterizedTest (JabRef#11033) Update teaching.md Remove non-existing recipe (JabRef#11029) Update CSL styles (JabRef#11031) Clean up defintions of entry types (JabRef#11013) Fix log file path on Windows (JabRef#11028) Change to rolling logs (JabRef#11023) chore: remove repetitive words (JabRef#11015) Fix test names (JabRef#11014) ...
Siedlerchr
approved these changes
Mar 18, 2024
koppor
reviewed
Mar 19, 2024
| implementation 'org.apache.pdfbox:fontbox:3.0.2' | ||
| implementation ('org.apache.pdfbox:xmpbox:3.0.2') { | ||
| // 3.0.2 is buggy! | ||
| def pdfbox = "3.0.1" |
Member
There was a problem hiding this comment.
@Siedlerchr Do we really use variables here? This is the first time, I saw it. Does this work with dependabot? Shouldn't we add the exception to
Line 9 in 8ff0ae6
Member
There was a problem hiding this comment.
dependabot/dependabot-core#1618 (comment)
Did this for Lucene as well. Should work.
Good idea to add an exception to the yaml file
Member
There was a problem hiding this comment.
I remember maven files where in another file the versions were set. Or even in a dependency 🤣🤣
Good that we keep it close to the use 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHanges made in setupModeButtons to address toggling of buttons issue for the issue issue-10935
Both buttons can be toggled without the error
java.lang.RuntimeException: ToggleButton.selected : A bound value cannot be set.Can switch between Live and Locked mode now without the error
java.lang.RuntimeException: ToggleButton.selected : A bound value cannot be set.fixes #10935
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)