Skip to content

Fix "Document Viewer: PDF shows only in half of the window size" #10934#10961

Merged
Siedlerchr merged 2 commits into
JabRef:mainfrom
cardionaut:fix-issue-10934
Mar 2, 2024
Merged

Fix "Document Viewer: PDF shows only in half of the window size" #10934#10961
Siedlerchr merged 2 commits into
JabRef:mainfrom
cardionaut:fix-issue-10934

Conversation

@cardionaut

@cardionaut cardionaut commented Mar 2, 2024

Copy link
Copy Markdown
Contributor

Use setAsDialogPane in ViewLoader to correctly display the PDF when Document Viewer window is resized.
PDF_full_window_size
Closes #10934.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@cardionaut

Copy link
Copy Markdown
Contributor Author

Would you guys like me to try adding some QoL features to the Document Viewer?
For example, I was thinking about:

  • Add ability to change zoom using Ctrl + Scroll
  • Add ability to minimize Document Viewer window

Otherwise I would look for another issue to work on.
Thanks!

@Siedlerchr

Siedlerchr commented Mar 2, 2024

Copy link
Copy Markdown
Member

thanks for the fix, can you add a screenshot? otherwise I tested it and lgtm
I would suggest you open a new PR then

Regarding your suggestions, sounds great. Maybe @ThiloteE has some ideas as well

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 2, 2024
@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 2, 2024
Merged via the queue into JabRef:main with commit b52c99c Mar 2, 2024
@ThiloteE

ThiloteE commented Mar 2, 2024

Copy link
Copy Markdown
Member

I very much like your proposals :-) Sure, go ahead if you feel like it and have the time and knowledge, but don't feel forced to do it, if you get stuck. I don't think many people used the document viewer. If we really wanted to make this a great feature that can compete with third party software (e.g. Okular, Foxit PDF reader, Adobe Reader etc.), it would require a complete rewrite, which I am not sure is really something we want at the current time, unless it is necessary to implement another great feature, such as summarizing documents utilizing large language models.

@cardionaut

Copy link
Copy Markdown
Contributor Author

thanks for the fix, can you add a screenshot? otherwise I tested it and lgtm
I would suggest you open a new PR then

Regarding your suggestions, sounds great. Maybe @ThiloteE has some ideas as well

Do you mean a new PR for the screenshot?
Thanks for the feedback!

@cardionaut

Copy link
Copy Markdown
Contributor Author

I very much like your proposals :-) Sure, go ahead if you feel like it and have the time and knowledge, but don't feel forced to do it, if you get stuck. I don't think many people used the document viewer. If we really wanted to make this a great feature that can compete with third party software (e.g. Okular, Foxit PDF reader, Adobe Reader etc.), it would require a complete rewrite, which I am not sure is really something we want at the current time, unless it is necessary to implement another great feature, such as summarizing documents utilizing large language models.

Thanks for the feedback, I won't spend too much time on it in this case :)

@ThiloteE

ThiloteE commented Mar 3, 2024

Copy link
Copy Markdown
Member

Ok :-)
You can simply edit your prior comment on GitHub to add a screenshot. No new PR required.

@cardionaut cardionaut deleted the fix-issue-10934 branch March 3, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: external-files status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document Viewer: PDF shows only in half of the window size

3 participants