Hi, thanks for your interest in JabRef and OpenSource. I like the change to the ui, yet i have a comment about your implementation. I recommend the book Effective Java by Josh Bloch. Here is a summary that I like to use myself: https://github.com/HugoMatilla/Effective-JAVA-Summary

@calixtus Hi, thanks for the feedback. I will check the resources you provided and modify the code.

You could disable the field if it's not selected (e.g binding)
And regarding the exception handling, better is to use Validation

Shouldn't the keys be hidden behind asterisks
@JabRef/developers ?

Yeah, maybe some kind of PasswordField or something similar can be used

@koppor I made that you can't enter a key unless you enable the check. 0914142

Should I make it the opposite: if you enter a key then the checkbox will be enabled?

Yeah, the opposite is great. The checkmark should automatically be set then.

Maybe no disablement of the checkbox. There seem to be two kinds of user flows 🤣🤣

On dialog close, the key should only be enabled if non empty.

@koppor Just to make sure I understood right.

• If a user enter a key the checkbox is enabled automatically
• if the key is empty the checkbox is disabled automatically

Also, can the user change the checkbox manually?

@koppor Just to make sure I understood right.

You came up with an even better solution!

Go for it!

Until now it was also possible to store custom keys, even if they are not used. Would be a regression if we automatically use the key if stored or remove it, when unchecked...

@calixtus Sorry, I saw your comment after I commited.
So, should I make the user able to edit both manually?

There are use cases one would want to keep the custom API stored without using it, maybe just to test something maybe.

I think the code is ready for review now.

From my side lgtm, just one minor addition: Can you add the note that is at the tab Citation key patterns, here as well?