Skip to content

Fix "Changing owner name crashes the application"#10932

Merged
koppor merged 3 commits into
mainfrom
fix-10924
Feb 28, 2024
Merged

Fix "Changing owner name crashes the application"#10932
koppor merged 3 commits into
mainfrom
fix-10924

Conversation

@koppor

@koppor koppor commented Feb 27, 2024

Copy link
Copy Markdown
Member

Fixes #10924

At #9910 I did not properly use our subscription system.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr reviewed Feb 27, 2024
View reviewed changes
Comment thread src/main/java/org/jabref/preferences/JabRefPreferences.java
internalPreferences = null;

// this propagates down to filePreferences
getInternalPreferences().getUserAndHostProperty().setValue(newValue);

@Siedlerchr Siedlerchr Feb 27, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this property is both in the owner preferences and the internal prefs. This looks like it should be only in one place

@koppor koppor Feb 28, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed follow-up issue https://github.com/JabRef/jabref-issue-melting-pot/issues/362

@github-actions

github-actions Bot commented Feb 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr

Siedlerchr commented Feb 27, 2024

Copy link
Copy Markdown
Member

As a quick fix okay, but we should really merge the preferences

@koppor koppor enabled auto-merge February 28, 2024 15:59
@koppor koppor added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit 16a526f Feb 28, 2024
@koppor koppor deleted the fix-10924 branch February 28, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Changing owner name crashes the application

2 participants

@koppor @Siedlerchr