Skip to content

Fix issue in comments Tab#10927

Merged
koppor merged 4 commits into
JabRef:mainfrom
LoayGhreeb:fix-for-issue-10870
Feb 27, 2024
Merged

Fix issue in comments Tab#10927
koppor merged 4 commits into
JabRef:mainfrom
LoayGhreeb:fix-for-issue-10870

Conversation

@LoayGhreeb

Copy link
Copy Markdown
Member

Fixes #10870

This issue occurs when the defaultOwner contains capital letters.
For example, if defaultOwner = Test, the userSpecificCommentField.name will be comment-Test, after saving it to the .bib file, it will be written as comment-test. As a result, every time the commentsTab is opened, it will contain both comment-Test and comment-test fields.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@LoayGhreeb LoayGhreeb changed the title Update CommentsTab.java Fix formatting issue in comments Tab Feb 26, 2024
@LoayGhreeb LoayGhreeb changed the title Fix formatting issue in comments Tab Fix issue in comments Tab Feb 26, 2024
Comment thread src/main/java/org/jabref/gui/entryeditor/CommentsTab.java
Comment thread src/main/java/org/jabref/gui/entryeditor/CommentsTab.java Outdated
Comment thread src/main/java/org/jabref/gui/entryeditor/CommentsTab.java Outdated
@koppor

koppor commented Feb 26, 2024

Copy link
Copy Markdown
Member

I could not check the failing ui test org.jabref.gui.entryeditor.CommentsTabTest

@LoayGhreeb LoayGhreeb requested a review from koppor February 26, 2024 23:30
Comment thread src/main/java/org/jabref/gui/entryeditor/CommentsTab.java Outdated
@koppor

koppor commented Feb 27, 2024

Copy link
Copy Markdown
Member

Code looks good. Did not try fully, but let's see, what users report ^^.

@koppor koppor added this pull request to the merge queue Feb 27, 2024
Merged via the queue into JabRef:main with commit 27f3ed6 Feb 27, 2024
@LoayGhreeb LoayGhreeb deleted the fix-for-issue-10870 branch February 27, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-editable user comments

3 participants