Skip to content

improve notification toast when saving a file #9803#10828

Merged
Siedlerchr merged 3 commits into
JabRef:mainfrom
rdsingh13:fix-for-issue-9803
Feb 12, 2024
Merged

improve notification toast when saving a file #9803#10828
Siedlerchr merged 3 commits into
JabRef:mainfrom
rdsingh13:fix-for-issue-9803

Conversation

@rdsingh13

@rdsingh13 rdsingh13 commented Jan 29, 2024 •
edited by ThiloteE
Loading

Copy link
Copy Markdown
Contributor

Closes #9803

I commented Saving library because its take no time in saving library so only one notification came Library saved

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus

calixtus commented Jan 29, 2024

Copy link
Copy Markdown
Member

Hi, thanks for your interest in jabref and open source programming.
Is there any issue linked to this pr you are fixing? Could you elaborate a bit on this description, whats the reasoning for your change?

@calixtus

calixtus commented Jan 29, 2024

Copy link
Copy Markdown
Member

Just saw the PR title.
Please note that GitHub does not parse pr titles, only the description of your pr. So if you automatically want to link your pr to an issue, you have to write fixes or closes followed by the issue number in the description. Like this:
Closes #9803

@calixtus

calixtus commented Jan 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

After reading through your changes and the issue description:
If you want to remove code, remove it, not just comment it. To keep a history of code changes is what git is for.
Secondly, the issue comments indicated, that there has not been yet a decision made on how to deal with the notifications. I will put a dev call tag on this one therefor.

@Siedlerchr

Siedlerchr commented Jan 29, 2024

Copy link
Copy Markdown
Member

Do not remove this. for lage libraries it will take some time

koppor
koppor requested changes Jan 29, 2024
View reviewed changes
Comment thread src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-9803
4378e0d 
* upstream/main: (68 commits)
  BibTeX 'Title' to MS Office 'Publicationtitle' field (JabRef#10864)
  Introduce BibliographyConsistencyCheckResultTxtWriter (JabRef#10847)
  Upgrade gradle-build-action to actions/setup-gradle (JabRef#10866)
  Bump org.apache.lucene:lucene-core from 9.9.1 to 9.9.2 (JabRef#10860)
  Bump org.junit.jupiter:junit-jupiter from 5.10.1 to 5.10.2 (JabRef#10863)
  Bump org.apache.lucene:lucene-highlighter from 9.9.1 to 9.9.2 (JabRef#10861)
  Bump org.tinylog:tinylog-api from 2.6.2 to 2.7.0 (JabRef#10862)
  Bump org.apache.lucene:lucene-queryparser from 9.9.1 to 9.9.2 (JabRef#10859)
  Bump gradle/wrapper-validation-action from 1 to 2 (JabRef#10858)
  Bump codecov/codecov-action from 3 to 4 (JabRef#10857)
  Bump peter-evans/create-pull-request from 5 to 6 (JabRef#10856)
  Update Gradle Wrapper from 8.5 to 8.6. (JabRef#10854)
  Enable auto merge of gradle wrapper update
  Jump to entry from cli (JabRef#10578)
  Fix closing of JabRef in case of issues with index writer (JabRef#10840)
  Update deployment-arm64.yml
  use nio path
  fix submodules
  Fix secrents presence chcek
  Update deployment-arm64.yml
  ...
@Siedlerchr
add 2000 entries check
3150d3a 
fix changelog for ms office export
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 11, 2024
@Siedlerchr Siedlerchr enabled auto-merge February 11, 2024 17:25
@Siedlerchr Siedlerchr added this pull request to the merge queue Feb 12, 2024
Merged via the queue into JabRef:main with commit 1ebe802 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve notification toasts when saving a file

4 participants

@rdsingh13 @calixtus @Siedlerchr @koppor