Implement scrollable warning messages in alert boxes#10700
Merged
Merged
Conversation
…ing within the alertbox.
…n function, displaying its contents on separate lines.
koppor
requested changes
Dec 16, 2023
koppor
left a comment
Member
There was a problem hiding this comment.
Thank you for taking initiative! - Please ensure that you have JabRef's code style settings in place. Checkstyle complains about wrong import order.
I wonder whether there can be tests added?
At least for getErrorMessages() there should be a test.
Reason: This is a logic module - and one or more tests can help enhancing that core funtionality.
Contributor
Author
|
I'll work on getting a test setup soon. Let me know if I committed incorrectly. Still trying to get a hang of this haha. |
calixtus
approved these changes
Dec 18, 2023
koppor
approved these changes
Dec 18, 2023
Member
|
@garymejia Thank you for the PR. We will merge it. You can add test cases as a follow-up if you want! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a scrollbar to the "Open library error" popup window to prevent extension beyond the screen when handling large bib files with citation errors. This enhancement ensures the window remains within the screen boundaries.
Closes #10674
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)