Draft Pull Request about #10615 Copy cite command should respect preferences#10690
Closed
OvercloudX wants to merge 3 commits into
Closed
Draft Pull Request about #10615 Copy cite command should respect preferences#10690OvercloudX wants to merge 3 commits into
OvercloudX wants to merge 3 commits into
Conversation
…nPreferences to CitationKeyGenerationPreferences. 2.Modify org.jabref.preferences.ExternalApplicationsPreferences#getCiteCommand to return a record. Creat and Name the record CitationCommandStringPreferences. 3.Tried to add a JUnit test
…nPreferences to CitationKeyGenerationPreferences. 2.Modify org.jabref.preferences.ExternalApplicationsPreferences#getCiteCommand to return a record. Creat and Name the record CitationCommandStringPreferences. 3.Tried to add a JUnit test
…nPreferences to CitationKeyGenerationPreferences. 2.Modify org.jabref.preferences.ExternalApplicationsPreferences#getCiteCommand to return a record. Creat and Name the record CitationCommandStringPreferences. 3.Tried to add a JUnit test
Member
|
@OvercloudX I see a merge conflict here. Take this PR as an opportunity to learn how to resolve merge conflicts. |
6 tasks
Member
|
@OvercloudX Thank you for your first initiative. Since this was release-critical, we fixed it for ourselves (which was fast due to our 10+years developer experience). #10707 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #10615
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)