Skip to content

Remove comments - don't work on forks#10649

Merged
Siedlerchr merged 1 commit into
mainfrom
remove-commenting
Nov 20, 2023
Merged

Remove comments - don't work on forks#10649
Siedlerchr merged 1 commit into
mainfrom
remove-commenting

Conversation

@koppor

@koppor koppor commented Nov 20, 2023

Copy link
Copy Markdown
Member

I thought it would be nice to have some messages at PRs when sth goes wrong.

However, only persons with access rights to this repo get these texts - others not.

Thus, I remove them.

@reviewdog can. Follow-up is to convert the output in case of errors to a format consumable to reviewdog.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr merged commit 3956934 into main Nov 20, 2023
@Siedlerchr Siedlerchr deleted the remove-commenting branch November 20, 2023 14:57
@github-actions

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants