Skip to content

Check if value is already a Short DOI#10612

Merged
Siedlerchr merged 3 commits into
JabRef:mainfrom
michalfarago:ShortDOI-check
Nov 2, 2023
Merged

Check if value is already a Short DOI#10612
Siedlerchr merged 3 commits into
JabRef:mainfrom
michalfarago:ShortDOI-check

Conversation

@michalfarago

@michalfarago michalfarago commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

Closes #10589

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

- Introduced predicate to check if the value is already a short DOI
- UTest
Siedlerchr
Siedlerchr previously approved these changes Nov 1, 2023

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
please add a changelog entry

- Added entry to CHANGELOG
- Modified the regex pattern
@michalfarago michalfarago marked this pull request as ready for review November 2, 2023 07:54
@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 2, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 2, 2023
@Siedlerchr Siedlerchr merged commit edc2cb2 into JabRef:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shortDOI formatter is very slow

3 participants