Split Java code style checks#10532
Merged
Merged
Conversation
5 tasks
Siedlerchr
previously approved these changes
Oct 21, 2023
Siedlerchr
approved these changes
Oct 21, 2023
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Member
Author
|
Build hangs, because I renamed the tests (to be more fine grained). Will merge and then adapt our CI requirements. Thus, all PRs need to merge main. |
Member
Author
|
For reference, new branch protection rules:
|
Member
Author
|
For reference, this is the output if something is really wrong - source: #10571 (comment)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is hard for newcomers to know about that we have more than checkstyle in place. See #10496 (comment).
We (currently) don't have it in the documentation. This is future work.
I think, it is more helpful, if we automatically comment on the PR to support tailored guidance. This PR tries to do it.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)