Added Fetcher for ISIDORE#10518
Merged
Merged
Conversation
Created a fetcher that would automatically fill referencing information from ISIDORE. Unfortunately the XML files are not always formatted the same way which increased the number of methods in this fetcher compared to the others.
Added the ISIDOREFetcher to the list of WebFetchers, on line 149.
Added tests for the ISIDORE fetcher.
Fixed case where doi would not be added correctly.
Added ISIDORE's privacy policy link to PRIVACY.md.
Siedlerchr
reviewed
Oct 19, 2023
koppor
requested changes
Oct 20, 2023
koppor
left a comment
Member
There was a problem hiding this comment.
Thank you for your work. Thank you also for putting test cases.
Comments for improvement attached.
…s) and fixed typo.
koppor
requested changes
Oct 21, 2023
koppor
left a comment
Member
There was a problem hiding this comment.
Thank you for continuing working.
Some code comments attached to level-up your coding skills!
Siedlerchr
reviewed
Oct 21, 2023
added 3 commits
October 22, 2023 12:14
Member
|
Current status: Isidore science seems buggy we always get an empty input stream back. |
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Member
|
We think, the API as of today returns and empty result if too many words are requested. |
Member
|
The API is a PITA. If too much word are queried, no results are returned. In case there is a real user need to include this API, the PR is "finished". It at least returns some results for less keywords. |
koppor
previously approved these changes
Jan 15, 2024
koppor
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a fetcher for the webside ISIDORE, (https://isidore.science/). The fetcher will get all the fields that it can find and will convert them into a BibEntry.
Fixes #10423.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)