Skip to content

Simplify inclusion of csl-*#10482

Merged
koppor merged 4 commits into
mainfrom
change-csl-path
Oct 12, 2023
Merged

Simplify inclusion of csl-*#10482
koppor merged 4 commits into
mainfrom
change-csl-path

Conversation

@koppor

@koppor koppor commented Oct 12, 2023

Copy link
Copy Markdown
Member

Follow-up to #10298. With the usage of git submodules, we do not need any file copy operations any more.

This refs https://discourse.jabref.org/t/lack-of-entry-preview-styles/4018.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Comment thread .gitmodules Outdated
url = https://github.com/JabRef/abbrv.jabref.org.git
[submodule "buildres/csl-styles"]
path = buildres/csl/csl-styles
path = src/main/resources/csl-styles

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
File contains tab characters (this is the first instance).

@koppor koppor marked this pull request as draft October 12, 2023 12:47
@Siedlerchr

Copy link
Copy Markdown
Member

we need to update the devdocs to add recurse submodules as parameter

@koppor koppor mentioned this pull request Oct 12, 2023
@koppor

koppor commented Oct 12, 2023

Copy link
Copy Markdown
Member Author

we need to update the devdocs to add recurse submodules as parameter

Done. Also removed a hint, because #9783 is fixed.

@koppor koppor mentioned this pull request Oct 12, 2023
@koppor koppor marked this pull request as ready for review October 12, 2023 13:03
@github-actions

github-actions Bot commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor enabled auto-merge October 12, 2023 13:48
@koppor koppor added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 16113d2 Oct 12, 2023
@koppor koppor deleted the change-csl-path branch October 12, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants