Fix triggers for deployment#10319
Merged
Merged
Conversation
Member
Author
|
Needs to be tested. Test PR is #10309. Therefore, I merge and then test at the PR (with re-activated branching rules) |
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
This was referenced Sep 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had the issue that the deployment workflow as not triggered for some PRs. See #9769 (comment).
The reason was a wrong trigger. We had the idea that binaries should only be created if there actually was changed something leading to changes in the binaries. Only changing tests does not lead to a change in the binary. For instance, test-only PRs do not change the binary. -- GitHub's branch protection rules demand that the workflows run. Regardless if the trigger ignores the changes. Thus, either make the workflows success optional - or trigger the workflow always.
Since test-only PRs are very seldom and we do want to have the deplyoment required, I remove the "filter" at the trigger.
Kind of hotfix.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)