Skip to content

Push to external application config#10303

Merged
Siedlerchr merged 37 commits into
mainfrom
pushToExternalConfig
Sep 4, 2023
Merged

Push to external application config#10303
Siedlerchr merged 37 commits into
mainfrom
pushToExternalConfig

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Sep 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #10133

grafik

Needs testing for emacs, vim and winEdt and textstudio etc

  • sublime text
  • vim
  • emacs
  • texstudio
  • WinEdt

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

github-actions[bot]
github-actions Bot reviewed Sep 3, 2023
View reviewed changes
Comment thread src/main/java/org/jabref/gui/push/PushToEmacs.java Outdated
Comment thread src/main/java/org/jabref/gui/push/PushToEmacs.java Outdated
Comment thread src/main/java/org/jabref/gui/push/PushToEmacs.java Outdated
Comment thread src/main/java/org/jabref/gui/push/PushToSublimeText.java Outdated
Comment thread src/main/java/org/jabref/gui/push/PushToSublimeText.java Outdated
Comment thread src/main/java/org/jabref/gui/push/PushToSublimeText.java Outdated
Comment thread src/main/java/org/jabref/gui/push/PushToSublimeText.java Outdated
Comment thread src/main/java/org/jabref/gui/push/PushToSublimeText.java Outdated
Comment thread src/main/java/org/jabref/gui/push/PushToWinEdt.java Outdated
Comment thread src/main/java/org/jabref/preferences/ExternalApplicationsPreferences.java Outdated
@github-actions

github-actions Bot commented Sep 3, 2023

Copy link
Copy Markdown
Contributor

Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.

More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html.

@Siedlerchr
fix checkstyle
6b87071
@Siedlerchr
fix imports
3de2baf
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into pushToExternalConfig
11bbbd0 
* upstream/main:
  Use OpenRewrite UseStringReplace (#10299)
  Add ReplaceStringBuilderWithString (#10302)
  Apply ShortenFullyQualifiedTypeReferences (#10301)
  Apply StaticMethodNotFinal (#10300)
  Apply exit early pattern (#10297)
  Avoid GH_TOKEN_UPDATE_GRADLE_WRAPPER at refresh-csl-subtrees
  Update snapcraft.yaml
  Fix exception when opening preferences (#10294)
  gnome-42-2204
  use gnome 4.2
  Use gnome
  Update base 22
@Siedlerchr
checkstyle
ebbb5ab
@Siedlerchr
checkstyle the xt
d3d7cd0
@Siedlerchr
Update JabRef_en.properties
9ed8713
@Siedlerchr

Siedlerchr commented Sep 3, 2023

Copy link
Copy Markdown
Member Author

@AdamWysokinski I implemented a first version and I tested it with sublime on mac.
Would be nice if you could test this as well:
https://builds.jabref.org/pull/10303/merge/

I used this pattern, as this works with multiple citations as well:
grafik

@AdamWysokinski

AdamWysokinski commented Sep 3, 2023

Copy link
Copy Markdown
Contributor

Tested with SublimeText on Linux. Works exactly as expected, THANK YOU!

@koppor

koppor commented Sep 3, 2023

Copy link
Copy Markdown
Member

TeXStudio:

grafik

grafik

@koppor

koppor commented Sep 3, 2023

Copy link
Copy Markdown
Member 
[@key1;@key2]

[@
;@
]

\cite{key1,key2}

@Siedlerchr

Siedlerchr commented Sep 3, 2023

Copy link
Copy Markdown
Member Author

[@key1;@key2] is now the new syntax

@Siedlerchr Siedlerchr enabled auto-merge September 4, 2023 00:05
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 4, 2023
@Siedlerchr Siedlerchr disabled auto-merge September 4, 2023 00:13
@koppor

koppor commented Sep 4, 2023

Copy link
Copy Markdown
Member

Not working with TeXStudio:

grafik

github-actions[bot]
github-actions Bot reviewed Sep 4, 2023
View reviewed changes
Comment thread src/test/java/org/jabref/gui/push/PushToEmacsTest.java Outdated
Comment thread src/test/java/org/jabref/gui/push/PushToEmacsTest.java
Comment thread src/test/java/org/jabref/gui/push/PushToEmacsTest.java
@github-actions

github-actions Bot commented Sep 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr enabled auto-merge September 4, 2023 13:33
@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 4, 2023
Merged via the queue into main with commit eaabae5 Sep 4, 2023
@Siedlerchr Siedlerchr deleted the pushToExternalConfig branch September 4, 2023 14:01
@koppor koppor mentioned this pull request Oct 24, 2023
Closed
2 tasks
@koppor koppor mentioned this pull request Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature request: Markdown [@key] cite command

4 participants

@Siedlerchr @AdamWysokinski @koppor @calixtus