Skip to content

Fix window pos not remembered#10128

Merged
Siedlerchr merged 4 commits into
mainfrom
fixWindowFullscreen
Jul 31, 2023
Merged

Fix window pos not remembered#10128
Siedlerchr merged 4 commits into
mainfrom
fixWindowFullscreen

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Jul 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #4939

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 30, 2023
@github-actions

github-actions Bot commented Jul 30, 2023

Copy link
Copy Markdown
Contributor

Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.

More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html.

@Siedlerchr Siedlerchr changed the title Fix window fullscreen Fix window pos not remembered Jul 31, 2023
@github-actions

github-actions Bot commented Jul 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr merged commit 52cbee5 into main Jul 31, 2023
@Siedlerchr Siedlerchr deleted the fixWindowFullscreen branch July 31, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor approved these changes

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

platform: macos status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JabRef window expands to full screen on app start

3 participants

@Siedlerchr @koppor @calixtus