Add ability to use ISBN & ArXiv ID in websearch#10063
Merged
Merged
Conversation
calixtus
previously approved these changes
Jul 3, 2023
Member
|
😍 |
Member
|
Thank you for the ongoing good contributions @aqurilla! The "design" added in this PR allows for adding RFC and other IDs easily. Let's see when users will ask for it. |
Contributor
Author
|
Glad to hear that, thankyou! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #7575 by adding a pre-processing step to the web search, using
org.jabref.logic.importer.CompositeIdFetcher.This is a followup to PR #9969, and extends the logic to cover ISBN and ArXiv ID cases as well.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)