Skip to content

Get notarization running on GitHub#10041

Merged
koppor merged 26 commits into
mainfrom
fix-notary-tool
Jul 1, 2023
Merged

Get notarization running on GitHub#10041
koppor merged 26 commits into
mainfrom
fix-notary-tool

Conversation

@koppor

@koppor koppor commented Jun 26, 2023 •
edited by Siedlerchr
Loading

Copy link
Copy Markdown
Member

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/24

Refs: https://docs.oracle.com/en/java/javase/20/jpackage/support-application-features.html#GUID-8D9F0607-91F4-4070-8823-02FCAB12238D

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr

Siedlerchr commented Jun 26, 2023

Copy link
Copy Markdown
Member

To test the notarization workflow we need to create a tag

@Siedlerchr

Siedlerchr commented Jun 26, 2023

Copy link
Copy Markdown
Member

Notarization works now. just something with uploading/downloading to builds.jabref.org

@Siedlerchr

Siedlerchr commented Jun 27, 2023

Copy link
Copy Markdown
Member

Only piece missing is to copy the work flow parts now to the mac arm

@Siedlerchr

Siedlerchr commented Jun 28, 2023

Copy link
Copy Markdown
Member

https://github.com/JabRef/jabref/actions/runs/5400189417/jobs/9808895171?pr=10041
download artifact still goes with unsigned

@Siedlerchr

Siedlerchr commented Jun 28, 2023

Copy link
Copy Markdown
Member

Run actions/download-artifact@master
Starting download for JabRef-macOS-unsigned
Error: Unable to find an artifact with the name: JabRef-macOS-unsigned

@Siedlerchr
Update deployment.yml
4e68403 
fix artifact name
@Siedlerchr

Siedlerchr commented Jun 28, 2023

Copy link
Copy Markdown
Member

for arm64 I think we should rename the files before uploading etc, I am not sure if we otherwise overwrite the existing ones

@koppor koppor added this to the v5.10 milestone Jun 29, 2023
@koppor koppor mentioned this pull request Jun 29, 2023
Merged
6 tasks
@koppor

koppor commented Jun 30, 2023

Copy link
Copy Markdown
Member Author

The patched macos AARM64 workflow (https://github.com/JabRef/jabref/actions/workflows/deployment-arm64.yml) needs to run on this branch (fix-notary-tool) with notarization true.

The .pkg and .dmg at https://builds.jabref.org/pull/10041/merge/ should be notarized (as of now), ,because I activated notarization.

@koppor

koppor commented Jul 1, 2023

Copy link
Copy Markdown
Member Author

We are continuing tweaking the build workflows (e.g., #10049). Therefore, we merge. We can add fixes if needed later.

@koppor koppor marked this pull request as ready for review July 1, 2023 20:03
@koppor koppor merged commit d2c5e23 into main Jul 1, 2023
@koppor koppor deleted the fix-notary-tool branch July 1, 2023 20:03
@koppor koppor mentioned this pull request Jul 1, 2023
Merged
6 tasks
@calixtus calixtus mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v5.10

Development

Successfully merging this pull request may close these issues.

2 participants

@koppor @Siedlerchr