JabRef version
5.4 (latest release)
Operating system
Windows
Details on version and operating system
Windows 11
Checked with the latest development build
Steps to reproduce the behaviour
- Have a library with at least one entry having a PDF.
- Give JabRef time to generate the index.
- Change something in the database.
- Go to the background notification tab, where you get something like
Note the last item, from which one gets the impression that the whole index has been rebuild.
However, looking at the code:
|
indexingTaskManager.updateDatabaseName(tabTitle.toString()); |
is triggered by the "rename of the tab" (i.e. appending the star to signal the change of the library).
But luckily
|
public void updateDatabaseName(String name) { |
|
DefaultTaskExecutor.runInJavaFXThread(() -> this.titleProperty().set(Localization.lang("Indexing for %0", name))); |
|
} |
only updates the name, and doesn't really create a new index.
Proposed change:
- Extract some of the logic of
updateTabTitle to get a short display name for a database to a helper method.
- Make the database context a constructor argument of the indexing task manager (to make it clear that each library has its own manager)
- Then in the indexing task manager listen to changes of the filename (i.e rename) and update the title (using the extracted helper method from above)
cc @btut
Appendix
No response
JabRef version
5.4 (latest release)
Operating system
Windows
Details on version and operating system
Windows 11
Checked with the latest development build
Steps to reproduce the behaviour
Note the last item, from which one gets the impression that the whole index has been rebuild.
However, looking at the code:
jabref/src/main/java/org/jabref/gui/LibraryTab.java
Line 341 in 222d214
is triggered by the "rename of the tab" (i.e. appending the star to signal the change of the library).
But luckily
jabref/src/main/java/org/jabref/logic/pdf/search/indexing/IndexingTaskManager.java
Lines 118 to 120 in 222d214
only updates the name, and doesn't really create a new index.
Proposed change:
updateTabTitleto get a short display name for a database to a helper method.cc @btut
Appendix
No response