-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
XXE in MsBibImporter #4229
Copy link
Copy link
Closed
Labels
component: import-loaddev: code-qualityIssues related to code or architecture decisionsIssues related to code or architecture decisionsgood first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.
Metadata
Metadata
Assignees
Labels
component: import-loaddev: code-qualityIssues related to code or architecture decisionsIssues related to code or architecture decisionsgood first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.
Type
Fields
Give feedbackNo fields configured for issues without a type.
The Issue
An XML External Entity attack is a type of attack against an application that parses XML input. This attack occurs when XML input containing a reference to an external entity is processed by a weakly configured XML parser. This attack may lead to the disclosure of confidential data, denial of service, server side request forgery, port scanning from the perspective of the machine where the parser is located, and other system impacts.
Where the Issue Occurred
The following code snippet displays the usage of
DocumentBuilderFactorywithout disabling entities:jabref/src/main/java/org/jabref/logic/importer/fileformat/MsBibImporter.java
Line 40 in 2f5f2e5
The following code snippet displays the parsing of the XML:
jabref/src/main/java/org/jabref/logic/importer/fileformat/MsBibImporter.java
Line 58 in 2f5f2e5