Skip to content

Improve Architecture Tests #2617

@lenhard

Description

@lenhard

I just noticed that our architecture tests currently do not cover static imports and, therefore, are missing at least one dependency that we want to forbid.

The class org.jabref.logic.pdf.PdfAnnotationImporter currently includes this statement import static org.jabref.gui.importer.actions.OpenDatabaseAction.LOGGER. Apart from being totally unnecessary (there would be no problem in using an own logger for the class), this is also forbidden. A fix to this issue should:

  1. remove the dependency in PdfAnnotationImporter and using an own logger.
  2. enhance the ArchitectureTests to detect static imports (which could lead to discovering further errors that might not be as easy to fix)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions