-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Improve Architecture Tests #2617
Copy link
Copy link
Closed
Labels
[outdated] type: enhancementdev: code-qualityIssues related to code or architecture decisionsIssues related to code or architecture decisions
Metadata
Metadata
Assignees
Labels
[outdated] type: enhancementdev: code-qualityIssues related to code or architecture decisionsIssues related to code or architecture decisions
Type
Fields
Give feedbackNo fields configured for issues without a type.
I just noticed that our architecture tests currently do not cover static imports and, therefore, are missing at least one dependency that we want to forbid.
The class
org.jabref.logic.pdf.PdfAnnotationImportercurrently includes this statementimport static org.jabref.gui.importer.actions.OpenDatabaseAction.LOGGER. Apart from being totally unnecessary (there would be no problem in using an own logger for the class), this is also forbidden. A fix to this issue should:PdfAnnotationImporterand using an own logger.ArchitectureTeststo detect static imports (which could lead to discovering further errors that might not be as easy to fix)