-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Replace all setStyle(..) calls with proper styleClasses #15686
Copy link
Copy link
Labels
component: csscomponent: uigood first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.📌 Pinned📍 AssignedAssigned by assign-issue-action (or manually assigned)Assigned by assign-issue-action (or manually assigned)
Metadata
Metadata
Assignees
Labels
component: csscomponent: uigood first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.📌 Pinned📍 AssignedAssigned by assign-issue-action (or manually assigned)Assigned by assign-issue-action (or manually assigned)
Type
Fields
Give feedbackNo fields configured for code-quality.
Projects
StatusShow more project fields
Done
We have around 35 occurrences where we use
setStyle(..)in JabRef. The problem is that this usually hardcodes colors or style like insets. Therefore, custom themes (CSS) or other stylesheets like Atlanta will always be overwritten by this inline styles.Priority 1:
setStyle(..)calls that set a color. Those are the most critical one we should get rid.Priority 2:
setStyle(..)calls. Use generic style classes, like a.boldstyle class for bold text. We can reuse that and are good to goAdditional context
Example:
