-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Refine "REDACTED" replacement #13796
Copy link
Copy link
Labels
component: fetchergood first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.📍 AssignedAssigned by assign-issue-action (or manually assigned)Assigned by assign-issue-action (or manually assigned)
Metadata
Metadata
Assignees
Labels
component: fetchergood first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.📍 AssignedAssigned by assign-issue-action (or manually assigned)Assigned by assign-issue-action (or manually assigned)
Type
Fields
Give feedbackNo fields configured for task.
Projects
StatusShow more project fields
Done
In case of an error, they key is removed from the output.
Example:
You will get
The output looks a bit strange as one would expect that only the key is not shown - and thus, the URL makes the impression of being invalid
Task
jabref/jablib/src/main/java/org/jabref/logic/importer/FetcherException.java
Line 17 in 1aae72d
getRedactedUrl(jabref/jablib/src/main/java/org/jabref/logic/importer/FetcherException.java
Line 89 in 1aae72d
Stringinstead of Object.@VisibleForTesting@ParameterizedTestand@CsvSource. Hint: Use Ctrl+Shift+T to create a test class.To increase debugging - the first letter of the API key could still be output - please modify the regex accordingly.
Benefits
Learn how regular expressions work in Java