Skip to content

Housekeeping#55

Merged
JSkimming merged 9 commits intomasterfrom
housekeeping
Apr 5, 2019
Merged

Housekeeping#55
JSkimming merged 9 commits intomasterfrom
housekeeping

Conversation

@JSkimming
Copy link
Copy Markdown
Owner

@JSkimming JSkimming commented Apr 5, 2019 •
edited
Loading

These changes are almost completely non functional.

  1. Fix typo in the readme.
  2. Introduced the thread safe ListLogger to be used in testing.
  3. Prevent AggregateException propagation
  4. Update The NuGet packages used in testing.
  5. Version the archive of the tests results.
    • It makes it easier for side-by-side comparisons of test results.
  6. Use Chocolatey to install codecov for unit tests.
    • It's the windows way 🤷‍♂️
  7. Use csmacnz.coveralls for coveralls coverage uploads.
    • It seems to have better support than coveralls.io.
  8. Updated to the latest StyleCop

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2019 •
edited
Loading

Codecov Report

Merging #55 into master will decrease coverage by 1.73%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage     100%   98.26%   -1.74%     
==========================================
  Files           5        5              
  Lines         230      231       +1     
  Branches        7       11       +4     
==========================================
- Hits          230      227       -3     
- Partials        0        4       +4
Impacted Files Coverage Δ
....Core.AsyncInterceptor/ProxyGeneratorExtensions.cs 100% <ø> (ø) ⬆️
....AsyncInterceptor/AsyncDeterminationInterceptor.cs 100% <ø> (ø) ⬆️
...ore.AsyncInterceptor/ProcessingAsyncInterceptor.cs 92% <ø> (-8%) ⬇️
...stle.Core.AsyncInterceptor/AsyncInterceptorBase.cs 96.36% <100%> (-3.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12562fa...b386324. Read the comment docs.

@JSkimming JSkimming merged commit 898e831 into master Apr 5, 2019
@JSkimming JSkimming deleted the housekeeping branch April 5, 2019 14:34
@JSkimming JSkimming self-assigned this Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JSkimming JSkimming

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JSkimming