Convert internal field to public property to allow external access.#51
Merged
JSkimming merged 1 commit intoJSkimming:masterfrom Mar 8, 2019
StevenRasmussen:master
Merged
Convert internal field to public property to allow external access.#51JSkimming merged 1 commit intoJSkimming:masterfrom StevenRasmussen:master
JSkimming merged 1 commit intoJSkimming:masterfrom
StevenRasmussen:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 229 230 +1
Branches 7 7
=====================================
+ Hits 229 230 +1
Continue to review full report at Codecov.
|
Owner
|
LGTM, @brunoblank, @ndrwrbgs any objections? |
Collaborator
|
👍 Looks good to me |
Owner
|
@StevenRasmussen Release 1.7.0 has been pushed to NuGet. Many thanks for your contribution. |
Author
|
Many thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off - Thanks for this incredible library!! I just came across it recently. Here's the problem that I am facing and reason for this PR:
I am using the
IInterceptorSelectorinterface to filter the interceptors for specific methods. I am also using theIAsyncInterceptorinterface (through theAsyncInterceptorBaseclass).When the
IInterceptorSelector.SelectInterceptors()method is called, if I inspect the interceptors parameter, instead of seeing my specific implementation of anIAsyncInterceptorI see anAsyncDeterminationInterceptor. This isn't necessarily an issue but my filter criteria depends on me being able to see if one of the interceptors is my specificIAsyncInterceptorimplementation. As it stands now, I don't see a way of determining what the underlying interceptor is that is being used by theAsyncDeterminationInterceptorinstance.This PR simply exposes the previously
Privatefield as aPublicproperty now so that I can inspect the underlyingIAsyncInterceptor.