Accept IProxyGenerator instead-of OR in-addition-to ProxyGenerator#30
Merged
JSkimming merged 4 commits intoJSkimming:masterfrom Nov 11, 2017
Merged
Accept IProxyGenerator instead-of OR in-addition-to ProxyGenerator#30JSkimming merged 4 commits intoJSkimming:masterfrom
JSkimming merged 4 commits intoJSkimming:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 5
Lines ? 229
Branches ? 7
=======================================
Hits ? 229
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
Owner
|
@ndrwrbgs You're on 🔥 at the moment mate 👏👏👏 I'll be giving these PRs some love over the weekend. Thanks for the contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29.
I made two commits here (see the commit history in the PR). The first was an attempt at a non-breaking change for this, and for MOST users it would be non-breaking. However, there are edge cases around reflection and type inference - https://coding.abel.nu/2014/07/adding-an-overload-is-a-breaking-change/ .
The second properly moves the interfaces all over to IProxyGenerator, which was, as @JSkimming asked, a drop-in-place solution. As the nuget package already requires Castle >= 4.2.0, no changes to dependencies need to be made.