Maintenance / Minor changes#1050
Merged
agodemar merged 4 commits intoJSBSim-Team:masterfrom Mar 5, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1050 +/- ##
===========================================
+ Coverage 24.87% 41.37% +16.49%
===========================================
Files 168 198 +30
Lines 18908 24071 +5163
Branches 0 3170 +3170
===========================================
+ Hits 4704 9960 +5256
+ Misses 14204 14062 -142
- Partials 0 49 +49 ☔ View full report in Codecov by Sentry. |
Member
Author
|
The codecov report is back, confirming that this PR fixes the coverage job in |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings a number of minor changes and fixes:
MinGW32has been renamed toMinGWas MinGW is no longer limited to 32 bits as stated on their website.target_include_directories, following the lead of PR fix: target include directories #1022 (there are still a few places that useinclude_directoriesand this will be addressed in a later PR).test_inherit_with_extra_argsmore robust. Indeed there are some subtleties between__cinit__and__init__:root_dirandpm_rootare properly handled.FGFDMExechas no constructor__init__, there is no need to call it.