Merged
Conversation
Fixes `FGPropertyNode.set_double_value()` to behave like its C++ counterpart in the process (returns a boolean to indicate if the update of the property value has succeeded).
This was referenced Mar 3, 2024
|
Since all of the other control inputs are normalised between 0.0 and 1.0 (or -1.0 and 1.0), it seems strange that the mixture wouldn't be, but understood why that's necessary to work around an issue in one of the FDMs. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses 2 issues related to documentation:
Regarding the first issue, the problem is due to the lack of Doxygen documentation in
src/simgear/props/props.hxxwhich makespython/Doxy2PyDocStrings.pycrash. The problem has been fixed by including the documentation ofFGPropertyNode.get_double_value()andFGPropertyNode.get_double_value()directly inpython/JSBSim.pyx.in.In the process,
FGPropertyNode.set_double_value()has been fixed to behave like its C++ counterpart (returns a boolean to indicate if the update of the property value has succeeded).