Maintenance / Minor changes#1031
Merged
agodemar merged 5 commits intoJSBSim-Team:masterfrom Feb 5, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1031 +/- ##
=======================================
Coverage 24.87% 24.87%
=======================================
Files 168 168
Lines 18908 18908
=======================================
Hits 4704 4704
Misses 14204 14204 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings a number of minor changes:
python/CMakeLists.txtunder a singleif(WIN32)clause.python(a folderpython/srcwas inadvertently created by CMake with a copy of all the C++ source code).overridekeywords (warnings issued by clang on MacOSX).sprintfby calls tosnprintfto avoid buffer overflows (even if the risk was actually extremely remote assprintfwas used to printint,unsigned intordoublein a buffer of 128 bytes which is unlikely to overflow). This avoids warnings from clang on MacOSX.