Versioning system patch and MacOS fixes#65
Merged
Conversation
Remove -devel suffix and replace it with NOT_FOR_RELEASE for non-release builds Fix MacOS short version string, which requires semantic versioning with no suffix Fix MacOS Get Info string
bazineta
approved these changes
Nov 23, 2025
Collaborator
|
As a side note, the docs should build on the merge to master but fail here due to protection rules. So that failure is expected. |
Collaborator
Author
|
OK, great. I wondered about that. I figured the documentation label must've set it off? |
Collaborator
|
That's correct :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is expected to be a temporary patch until Allan decides what to do with the versioning system. It now properly formats the MacOS short version string so development software is properly indexed in a MacOS System Report. And for the first time ever properly populates the Info.plist Get Info string. The variable in place for that string was supposed to come from CPack, but it never worked there either. Since it is a constant string I hardwired it into CMakeLists.txt, as it never changes similar to the Bundle Identifier string. There was no sense to cluttering up the code to define that variable elsewhere.
Since Apple is quite strict on semantic versioning and empty strings in the property list file, this will not affect other platforms.
It properly fills in the property list file now for a non-release build so there should be no more
rejectedissues when submitting the app to Apple for notarization.The commit removes the possibility of a -rc suffix and replaces the -devel suffix with -NOT_FOR_RELEASE. I tried removing the versioning altogether for a non-release build, but that causes the popup to appear that says your software is out of date and wants you download js8call ver 2.2.0. That will be a separate fix.