Update js8call.desktop#64
Merged
Merged
Conversation
Update desktop file for linux with correct exec name
Collaborator
|
This is necessary and it is not necessary to change the icon name. This is essentially in the linux build scripts, which create their own desktop file and populate it during install. When I originally wrote those scripts I did not want to use the ready-made desktop file as the scripts install the binary and icon in different places than AppImage will use. I didn't figure it would be a good idea to modify the existing one, as the scripts were considered a temporary solution. |
Collaborator
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update desktop file for linux with correct exec name. Any reason to change the icon name? If not, feel free to push.