Skip to content

Addresses #193 Custom Descriptions for Frequencies#199

Merged
rruchte merged 1 commit into
JS8Call-improved:masterfrom
rruchte:frequency_descriptions
Feb 24, 2026
Merged

Addresses #193 Custom Descriptions for Frequencies#199
rruchte merged 1 commit into
JS8Call-improved:masterfrom
rruchte:frequency_descriptions

Conversation

@rruchte

@rruchte rruchte commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator
  • Enables custom descriptions for frequencies
  • Handle unreadable/unwritable frequencies file
  • Add delete key shortcut to frequencies and scheduled frequency change tables

@rruchte rruchte added this to the 2.6.0 milestone Feb 24, 2026
@rruchte rruchte added the enhancement New feature or request label Feb 24, 2026
@Joe-K0OG

Joe-K0OG commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

@rruchte Rob, I see that the CI build for Windows failed, so I patched main and tried to build on Windows (JTSDK64-Tools), and got similar errors:

[  0%] Built target JS8Call_autogen_timestamp_deps
[  1%] Automatic MOC and UIC for target JS8Call
[  1%] Built target JS8Call_autogen
[  2%] Building CXX object CMakeFiles/JS8Call.dir/JS8_Main/AprsInboundRelay.cpp.obj
[  3%] Building CXX object CMakeFiles/JS8Call.dir/JS8_Main/CandidateKeyFilter.cpp.obj
[  4%] Building CXX object CMakeFiles/JS8Call.dir/JS8_Main/FrequencyList.cpp.obj
[  5%] Building CXX object CMakeFiles/JS8Call.dir/JS8_Main/MetaDataRegistry.cpp.obj
[  5%] Building CXX object CMakeFiles/JS8Call.dir/JS8_Main/StationList.cpp.obj
[  6%] Building CXX object CMakeFiles/JS8Call.dir/JS8_Main/main.cpp.obj
C:\JTSDK64-Tools\tmp\wsjtx\JS8_Main\CandidateKeyFilter.cpp: In member function 'void CandidateKeyFilter::set_active_key
const QModelIndex&)
 In member function '
:                ':

n '                  error: '?
   64 |     'endFilterChangeendFilterChange();
      |     ' was not declared in this scope; did you mean '^~~~~~~~~~~~~~~beginFilterChange
      |     '?
  220 |     beginFilterChangeendFilterChange
();
      |     ^~~~~~~~~~~~~~~
      |     beginFilterChange
mingw32-make.exe[2]: *** [CMakeFiles\JS8Call.dir\build.make:500: CMakeFiles/JS8Call.dir/JS8_Main/CandidateKeyFilter.cpp.obj] Error 1
mingw32-make.exe[2]: *** Waiting for unfinished jobs....
mingw32-make.exe[2]: *** [CMakeFiles\JS8Call.dir\build.make:602: CMakeFiles/JS8Call.dir/JS8_Main/FrequencyList.cpp.obj] Error 1
mingw32-make.exe[1]: *** [CMakeFiles\Makefile2:89: CMakeFiles/JS8Call.dir/all] Error 2
mingw32-make.exe: *** [Makefile:90: all] Error 2

Looks like some interesting enhancements, so I look forward to testing.

73,
-Joe-
K0OG

@rruchte

rruchte commented Feb 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

I just saw that, I made that change to fix a deprecation warning on my system, I'm on QT 6.10.1. Will revert that change, it's not really related to the enhancements.

Screenshot From 2026-02-23 21-25-40

@rruchte rruchte force-pushed the frequency_descriptions branch 2 times, most recently from c84a194 to eeb742f Compare February 24, 2026 02:26
Chris-AC9KH
Chris-AC9KH approved these changes Feb 24, 2026
View reviewed changes

@Chris-AC9KH Chris-AC9KH left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rruchte yes, we're using Qt6.9.3, which was released on Sept 30 last year. I fixed some deprecations for earlier versions of Qt. But we really haven't looked at Qt 6.10 and I don't know if we will. It depends on their release schedule as 6.10 matures, and what they go to next. I generally like to stick to the latest point release of each Qt series, as the final is usually a big bug fix.

It was absolutely necessary to move to Qt6.9.3, as Apple deprecated Qt6.8 on MacOS 26 and it won't build on Tahoe. Plus Qt6.9.3 fixed the audio issues on Windows as well, that existed in Qt6.8.

Anyhow, this looks good to me.

@rruchte

rruchte commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator Author

@Chris-AC9KH I used to have QT pinned to 6.9.3, somehow that was ignored and QT got updated. I'll have to downgrade.

@rruchte
Addresses JS8Call-improved#193
97e4a07 
- Enables custom descriptions for frequencies
- Handle unreadable/unwritable frequencies file
- Add delete key shortcut to frequencies and scheduled frequency change tables
@rruchte rruchte force-pushed the frequency_descriptions branch from eeb742f to 97e4a07 Compare February 24, 2026 04:25
Joe-K0OG
Joe-K0OG approved these changes Feb 24, 2026
View reviewed changes

@Joe-K0OG Joe-K0OG left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature addition! Simple & effective.

I patched the latest main and built with no problems on Windows and Linux, and the resulting executables performed nicely. I see no particular reason to limit the length of text as I doubt that users will type much there anyway.

I think it's ready to go. Good work.

73l
-Joe-
K0OG

P.S. I'm building on both platforms with Qt6.9.3, as we agreed several months ago. My attempts to test with Qt6.10 were very unsuccessful - lots of problems.

@rruchte rruchte merged commit b2ea6c5 into JS8Call-improved:master Feb 24, 2026
@wmiler wmiler mentioned this pull request Mar 1, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chris-AC9KH Chris-AC9KH Chris-AC9KH approved these changes
@Joe-K0OG Joe-K0OG Joe-K0OG approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@rruchte @Joe-K0OG @Chris-AC9KH