Skip to content

Bug fix: #126 Set snr for Log window. Add debugging for LogQSO #178

Merged
Chris-AC9KH merged 4 commits into
JS8Call-improved:masterfrom
wmiler:logqso
Feb 15, 2026
Merged

Bug fix: #126 Set snr for Log window. Add debugging for LogQSO #178
Chris-AC9KH merged 4 commits into
JS8Call-improved:masterfrom
wmiler:logqso

Conversation

@wmiler

@wmiler wmiler commented Feb 1, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@wmiler wmiler requested a review from Chris-AC9KH February 1, 2026 21:32
@wmiler wmiler self-assigned this Feb 1, 2026
@wmiler wmiler added the bug Something isn't working label Feb 1, 2026
@Chris-AC9KH

Copy link
Copy Markdown
Collaborator

@wmiler this works, but I don't actually get a rptRcvd in the logging dialog without manually entering it. I did not run it with logging turned on to see what the debugging reports, however.

@wmiler

wmiler commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator Author

Yeah, rptRcvd isn't populated yet either. I've been fishing thru the code trying to figure where I can grab that from.

@Chris-AC9KH

Copy link
Copy Markdown
Collaborator

Without looking thru the code, off the top of my head it should be somewhere in the m_rptRcvd variable.

@wmiler

wmiler commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator Author

Without looking thru the code, off the top of my head it should be somewhere in the m_rptRcvd variable.

True, but that also isn't set, and seems to be only set when a person enters it. We don't track that anywhere except in snr? Or @hb responses and it's not saved as far as I can see.

@Chris-AC9KH

Copy link
Copy Markdown
Collaborator

Maybe you can grab it from snr_ in the DecodedText class? m_rptRcvd looks like a total oversight in the code with failure to connect it to anything.

@wmiler wmiler added the WIP Work In Progress label Feb 2, 2026
@wmiler

wmiler commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator Author

Marked as wip for now, I'll see if I can find a way to get rptRvcd to populate.

@wmiler

wmiler commented Feb 14, 2026

Copy link
Copy Markdown
Collaborator Author

Sorry for the delays, I broke my shoulder at the beginning of the month, just now starting to be able to get back in front of a computer.

@wmiler

wmiler commented Feb 14, 2026

Copy link
Copy Markdown
Collaborator Author

@Chris-AC9KH I don't see a logical way to get m_rptRcvd since it has to be sent by the other station to us. This isn't included in any MSG or other station-to-station communications, and we don't have a table or such for heartbeats or snr?. I think for now, that can't be implemented. If in the future, we hold the recv snr, that could change.

Don't merge this fix yet, I do have a small bit of clean up to do.

@wmiler wmiler added ready Ready to merge and removed WIP Work In Progress labels Feb 14, 2026
@Chris-AC9KH Chris-AC9KH merged commit d75c053 into JS8Call-improved:master Feb 15, 2026
@Chris-AC9KH

Copy link
Copy Markdown
Collaborator

Merged. Thanks!

@wmiler wmiler deleted the logqso branch February 15, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready Ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants