Add API updates. See docs/API.md Part 1#159
Conversation
Chris-AC9KH
left a comment
There was a problem hiding this comment.
While I didn't follow all the way thru API.md, the code that affects functionality in networkMessage.cpp is fine.
|
@wmiler Jeff's PR on the API js8call/js8call#92 will no longer merge into master. But can his code be copied into networkMessage.cpp giving him proper credit for it via comments? |
|
Mostly that can be done, it will need to be massaged more to get it into shape. And there are some bugs to be worked out of the API as a whole. I'm going to go ahead and mark this as a WIP for now. |
|
As we already have |
Yeah, I was considering that. Given that at the moment, you can only have one radio connected to one instance of JS8Call at a time. I suppose if that ever changes, we can always add a Station variant back in. |
|
Pushed a little early, so set_spot doesn't work yet, and get_spot is hackish, but I have the storm from h*ll bearing down on me. Request for test: API call STATION.GET_OS |
|
So we have a request to emit a 'CLOSE/SHUTDOWN' to the API before the program closes. I'm not exactly sure were that should be generated from, where I have access to networkMessage(). Any pointers? |
|
@Chris-AC9KH Chris, when you get a chance, double check the code, and feel free to merge. I want to get some of this on master so people can test. Thanks. |
|
The code syntax is sound. Can't vouch for the functionality of the code, I think that can only be determined with testing. |
|
Merged. Thanks! |
Part of #87