Fix APRS server connect bug.#157
Merged
Merged
Conversation
Collaborator
|
Looks like this should fix it. We'll merge and test from master. Thanks! |
Collaborator
|
I just tested pre-fixed code on both Linux and Windows, and verified the problem. Then built this fixed code on Linux and Windows, and verified that with the check-box un-ticked, no communication with the APRSIS server was observed, yet it does connect when the box is ticked. Good fix! 73, |
Collaborator
|
Same here, merged to master, built it and tested. Works fine now. It just needed a better logic to test if it's selected or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug where we connect to APRSIS even if we're not going to use it.