Skip to content

Remove deprecated DisplayManual class#151

Merged
Chris-AC9KH merged 1 commit into
JS8Call-improved:masterfrom
Chris-AC9KH:pr/remove-deprecated
Jan 20, 2026
Merged

Remove deprecated DisplayManual class#151
Chris-AC9KH merged 1 commit into
JS8Call-improved:masterfrom
Chris-AC9KH:pr/remove-deprecated

Conversation

@Chris-AC9KH

Copy link
Copy Markdown
Collaborator

Move OmniRig to deprecated group, scheduled for deprecation due to being no longer supported by Windows 11 and Qt6.9.3 This references #119 where the author of OmniRig clearly does not understand that his code must be ported to Qt 6.9.3 or newer. Qt does not keep deprecated stuff around to support an obsolete 32-bit program.

So OmniRig, as stated in CMakeLists.txt where the option is defined has one foot in the grave, the other on a banana peel. It is scheduled for deprecation from the codebase and is moved to that group.

@Chris-AC9KH Chris-AC9KH requested a review from wmiler January 19, 2026 13:04
@wmiler wmiler requested a review from Joe-K0OG January 19, 2026 16:08
@wmiler wmiler added the documentation Improvements or additions to documentation label Jan 19, 2026
@wmiler

wmiler commented Jan 19, 2026

Copy link
Copy Markdown
Collaborator

One liner change, at the top of OmniRigtransceiver.cpp add

@deprecated This class is deprecated and is scheduled for removal in release xxx

Where "xxx" is the date or version.

@Joe-K0OG Joe-K0OG left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree that this should be scheduled for removal. There are other approaches that operators can take to accomplish the same functionality as with OmniRig (e.g., rigctld.exe).

73,
-Joe-
K0OG

@Chris-AC9KH

Copy link
Copy Markdown
Collaborator Author

Yes, good idea. I'll do that.

Move OmniRig to deprecated group, scheduled for deprecation due
to being no longer supported by Windows 11 and Qt6.9.3
Schedule OmniRig to removed from the code in July 2026
Noted in the doxy file description
@Chris-AC9KH Chris-AC9KH merged commit 459ebef into JS8Call-improved:master Jan 20, 2026
@Chris-AC9KH Chris-AC9KH deleted the pr/remove-deprecated branch January 20, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants