Skip to content

Rename class files to match their class declarations in JS_Mode#145

Merged
Chris-AC9KH merged 1 commit into
JS8Call-improved:masterfrom
Chris-AC9KH:pr/class-fixups
Jan 17, 2026
Merged

Rename class files to match their class declarations in JS_Mode#145
Chris-AC9KH merged 1 commit into
JS8Call-improved:masterfrom
Chris-AC9KH:pr/class-fixups

Conversation

@Chris-AC9KH

@Chris-AC9KH Chris-AC9KH commented Jan 17, 2026

Copy link
Copy Markdown
Collaborator

This is a continued cleanup of the codebase. It renames four class files to match their class declarations. When code documentation is referred to, this helps with maintainability of the code by making it easier to identify the files that contain the class.

Trying to be a little less invasive now with each step of the code cleanup process.

@Chris-AC9KH Chris-AC9KH requested a review from wmiler January 17, 2026 03:27
@Chris-AC9KH

Copy link
Copy Markdown
Collaborator Author

@wmiler if you're happy with this one, please just merge it. I don't think it will affect work-in-process too much because these files aren't worked on too often. But it's best to not leave changes like this hanging just in case.

@Chris-AC9KH

Copy link
Copy Markdown
Collaborator Author

Oh, and yes, Xcode clang-format removed some whitespace from the doxy hooks in DecodedText

@wmiler wmiler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are both files in tools linking to QT5core? Should they not be linking to qt6?
Also, nitpick: Why are neither of the two tool files or varicode capitalized like every thing else?

@wmiler wmiler added the documentation Improvements or additions to documentation label Jan 17, 2026
@Chris-AC9KH

Copy link
Copy Markdown
Collaborator Author

No, those two diagnostic tools use Qt5. They are standalone tools used to tweak the kalman filter and frequency tracker, not members of any class. They can be named anything they want.

Varicode is that way because that's the way Jordan originally wrote it. I"m working on JS8_Mode right now. Haven't gotten to JS8_Main yet. I'll fix it when I get there. I'm trying to do this in smaller steps. But the UI is coming out of mainwindow next. That one is going to be big.

@wmiler

wmiler commented Jan 17, 2026

Copy link
Copy Markdown
Collaborator

Push it then

@Chris-AC9KH Chris-AC9KH merged commit 864aafe into JS8Call-improved:master Jan 17, 2026
@Chris-AC9KH Chris-AC9KH deleted the pr/class-fixups branch January 17, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants