Skip to content

Windows signing#136

Merged
wmiler merged 5 commits into
masterfrom
pr/ci-updates
Jan 15, 2026
Merged

Windows signing#136
wmiler merged 5 commits into
masterfrom
pr/ci-updates

Conversation

@wmiler

@wmiler wmiler commented Jan 14, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@wmiler wmiler self-assigned this Jan 14, 2026
@wmiler wmiler added ready Ready to merge and removed do not merge labels Jan 15, 2026
@wmiler

wmiler commented Jan 15, 2026

Copy link
Copy Markdown
Collaborator Author

@Chris-AC9KH Chris, this should now work correctly for regular CI builds, and as a manually run "Release" build, and can be run from a branch. Please note When running a "release" build, only JS8Call Admins can approve it to run (You, me, or Jordan currently), if you need me to change that to a different group, just let me know.

Github will only put out zipped artifacts, so still stuck with that.

The "release" signing key is the same as the CI key for now, but is easy to change when we get that far.

@wmiler wmiler merged commit 1136bc9 into master Jan 15, 2026
@wmiler wmiler deleted the pr/ci-updates branch January 15, 2026 03:05
@Chris-AC9KH

Copy link
Copy Markdown
Collaborator

@wmiler sounds good. The zipped artifacts aren't any big deal. I just unpack 'em and upload the AppImages and .exe installer. Works fine.

@wmiler

wmiler commented Jan 15, 2026

Copy link
Copy Markdown
Collaborator Author

Ok, good deal!
I have another PR coming prolly tomorrow afternoon that fixes up the AppImages in a similar manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants